Skip to content

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Nov 18, 2025

Description

Follow up to #708

The previous usage of hbase.rest.port by HBase defaulted to port 8080, this is the correct port HBase restserver should listen on internally on the container/Pod. By overriding it in #708 the restserver was listening on the port that was provided by the listener. But this new port should be used for external access not internally, so we can't use the hbase.rest.port key to advertise the restserver to the outside.

This approach was possible in master and regionserver roles, because those two had a patch https://github.com/stackabletech/docker-images/blob/main/hbase/hbase/stackable/patches/2.6.3/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch changing the behavior of the hbase.[master/regionserver].port keys, which are now used for advertising and hbase.[master/regionserver].ipc.port for internal port listening.

Using the same approach for restserver would require adding a similar patch for the restserver as well. @adwk67 and me discussed that it wouldn't make too much sense to put that much work into it before discussing Discovery 2.0, which might change the whole approach anyway.

Instead this PR changes the previously added hbase-site.xml keys so a single hbase.rest.endpoint one, providing the full advertised restserver address and not touch hbase.rest.port default behavior.

Integrationtests passed
🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/72/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Nov 18, 2025
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
@xeniape xeniape requested a review from razvan November 20, 2025 07:44
@xeniape xeniape marked this pull request as ready for review November 20, 2025 07:44
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Nov 20, 2025
razvan
razvan previously approved these changes Nov 20, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion otherwise it lgtm.

Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@xeniape xeniape added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit bdf0b19 Nov 20, 2025
17 checks passed
@xeniape xeniape deleted the fix/advertise-restserver-follow-up branch November 20, 2025 09:42
@xeniape
Copy link
Member Author

xeniape commented Nov 20, 2025

Release Note

Add hbase.rest.endpoint value to the restserver rolegroup configmap for advertising the restservers.

@xeniape xeniape added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 20, 2025
@xeniape xeniape moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

HBase Restserver startup probe failing with external listeners

4 participants