[Merged by Bors] - Documented service discovery #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

maltesander wants to merge 5 commits into main from document_service_discovery

Member

maltesander commented Mar 8, 2022

Description

closes #342

Review Checklist

Code contains useful comments
(Integration-)Test cases added (or not applicable)
Documentation added (or not applicable)
Changelog updated (or not applicable)
Cargo.toml only contains references to git tags (not specific commits or branches)
Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information


          documented service discovery

ba6b95c

maltesander requested a review from a team

March 8, 2022 14:12

razvan reviewed

View reviewed changes

docs/modules/ROOT/pages/discovery.adoc Outdated Show resolved Hide resolved

razvan reviewed

View reviewed changes

docs/modules/ROOT/pages/discovery.adoc Outdated Show resolved Hide resolved

razvan reviewed

View reviewed changes

docs/modules/ROOT/pages/discovery.adoc Outdated Show resolved Hide resolved

razvan reviewed

View reviewed changes

docs/modules/ROOT/pages/discovery.adoc Outdated Show resolved Hide resolved

razvan reviewed

View reviewed changes

Member

razvan left a comment

Some asciidoc fixes and suggestions.

maltesander added 4 commits

March 14, 2022 11:25


          adapted to pr review

d209b41


          adapted to pr review

0fe680b


          fixed callout highlighting

21d6d80


          removed icon font

350f004

razvan approved these changes

View reviewed changes

Member

razvan left a comment

lgtm

Member Author

maltesander commented Mar 14, 2022

bors merge

bors bot pushed a commit that referenced this pull request


          Documented service discovery (#367)

cb0cab5

## Description

closes #342



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

Contributor

bors bot commented Mar 14, 2022

Pull request successfully merged into main.

Build succeeded:

All tests passed

bors bot changed the title ~~Documented service discovery~~ [Merged by Bors] - Documented service discovery

bors bot closed this

bors bot deleted the document_service_discovery branch

March 14, 2022 11:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet