Skip to content

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Aug 12, 2025

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Documentation added or updated. Follows the style guide.
  • Changelog updated

Acceptance

  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added

@lfrancke lfrancke self-assigned this Aug 12, 2025
@lfrancke lfrancke moved this to Development: In Progress in Stackable Engineering Aug 12, 2025
@lfrancke lfrancke moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Aug 12, 2025
@lfrancke lfrancke enabled auto-merge August 12, 2025 11:20
@maltesander maltesander self-requested a review August 12, 2025 11:25
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 12, 2025
maltesander
maltesander previously approved these changes Aug 12, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, minor nitpicks.

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
lfrancke and others added 9 commits August 12, 2025 13:54
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lfrancke lfrancke added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit 079575e Aug 12, 2025
17 checks passed
@lfrancke lfrancke deleted the feat/docs-changes branch August 12, 2025 12:19
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only two small nitpicks

@lfrancke lfrancke mentioned this pull request Aug 12, 2025
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Aug 12, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants