Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer requested a review from labrenbe July 1, 2025 11:36
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jul 1, 2025
@sbernauer sbernauer self-assigned this Jul 1, 2025
Co-authored-by: Benedikt Labrenz <benedikt@labrenz.org>
@sbernauer sbernauer requested a review from labrenbe July 7, 2025 14:08
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 7, 2025
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer sbernauer enabled auto-merge July 8, 2025 06:10
@sbernauer sbernauer closed this Jul 8, 2025
auto-merge was automatically disabled July 8, 2025 06:10

Pull request was closed

@sbernauer sbernauer reopened this Jul 8, 2025
@sbernauer sbernauer enabled auto-merge July 8, 2025 06:14
@sbernauer sbernauer closed this Jul 8, 2025
auto-merge was automatically disabled July 8, 2025 06:56

Pull request was closed

@sbernauer sbernauer reopened this Jul 8, 2025
@NickLarsenNZ NickLarsenNZ merged commit a5a418c into main Jul 8, 2025
48 checks passed
@NickLarsenNZ NickLarsenNZ deleted the docs/uif-setup branch July 8, 2025 14:22
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 8, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jul 14, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jul 14, 2025
dervoeti pushed a commit that referenced this pull request Oct 29, 2025
* docs: Document how to configure user-info-fetcher Keycloak user

* Apply suggestions from code review

Co-authored-by: Benedikt Labrenz <benedikt@labrenz.org>

---------

Co-authored-by: Benedikt Labrenz <benedikt@labrenz.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants