Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Jul 7, 2025

Description

Document AD user filter implementation details as requested by this comment.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Jul 7, 2025
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jul 7, 2025
@razvan razvan requested a review from a team July 7, 2025 08:36
@razvan razvan enabled auto-merge July 7, 2025 09:09
@razvan razvan added this pull request to the merge queue Jul 7, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jul 7, 2025
Merged via the queue into main with commit dff61f2 Jul 7, 2025
17 checks passed
@razvan razvan deleted the docs/ad-user-filter branch July 7, 2025 11:31
@lfrancke
Copy link
Member

Can you please link to the generated docs for this?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jul 14, 2025
@razvan
Copy link
Member Author

razvan commented Jul 22, 2025

Can you please link to the generated docs for this?

The docs are linked in the parent issue.

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jul 22, 2025
@lfrancke lfrancke linked an issue Jul 22, 2025 that may be closed by this pull request
dervoeti pushed a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

User Info Fetcher: Retrieve user info by sAMAccountName

4 participants