Skip to content

fix: Add ENV to product config machinery to fix env overrides #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

fix: Add ENV to product config machinery to fix env overrides #754

merged 4 commits into from
Aug 5, 2025

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Aug 5, 2025 •
edited by sbernauer
Loading

Description

  • env variables and therefore env_overrides were not considered from product config machinery

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander requested a review from sbernauer August 5, 2025 07:46
@maltesander maltesander self-assigned this Aug 5, 2025
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Aug 5, 2025
lfrancke
lfrancke previously approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but I assume the test works. Looks good to me, thank you for adding the test!

sbernauer
sbernauer reviewed Aug 5, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
Can you please add a changelog entry?

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 5, 2025
@sbernauer sbernauer changed the title Fix: Add ENV to product config machinery to fix env overrides fix: Add ENV to product config machinery to fix env overrides Aug 5, 2025
@maltesander maltesander requested a review from sbernauer August 5, 2025 08:23
sbernauer
sbernauer reviewed Aug 5, 2025
View reviewed changes
@maltesander @sbernauer
Update CHANGELOG.md
81ac735 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
sbernauer approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maltesander maltesander enabled auto-merge August 5, 2025 08:30
@maltesander maltesander added this pull request to the merge queue Aug 5, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 5, 2025
Merged via the queue into main with commit 196c441 Aug 5, 2025
17 checks passed
@maltesander maltesander deleted the fix/env-overrides branch August 5, 2025 08:42
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Aug 5, 2025
@lfrancke
Copy link
Member

lfrancke commented Aug 11, 2025 •
edited
Loading

Can you please add a release note snippet?

Please use the form "Previously, this went wrong. With this release, this was fixed in the following way."

@maltesander
Copy link
Member Author

maltesander commented Aug 11, 2025

Release note:

Previously the opa-operator ignored `envOverrides` set on role or rolegroup level. With this release, the `envOverrides` are propagated by the operator.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 11, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Aug 11, 2025
dervoeti pushed a commit that referenced this pull request Oct 29, 2025
@maltesander @sbernauer @dervoeti
fix: Add ENV to product config machinery to fix env overrides (#754)
93be2e3 
* add env to product config

* add changelog

* check for role env var

* Update CHANGELOG.md

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

---------

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

@lfrancke lfrancke lfrancke left review comments

Assignees

@maltesander maltesander

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maltesander @lfrancke @sbernauer