Skip to content

fix: Unit test 'test_validate_ok' #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labrenbe merged 1 commit into from
Nov 6, 2025
Merged

fix: Unit test 'test_validate_ok' #66

labrenbe merged 1 commit into from
Nov 6, 2025

Conversation

@labrenbe
Copy link
Member

@labrenbe labrenbe commented Nov 6, 2025

Description

Fixes the unit test test_validate_ok which is broken on branches other than main.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@labrenbe labrenbe self-assigned this Nov 6, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@labrenbe labrenbe added this pull request to the merge queue Nov 6, 2025
Merged via the queue into main with commit 02453ec Nov 6, 2025
13 checks passed
@labrenbe labrenbe deleted the fix/test-validate-ok branch November 6, 2025 11:22
labrenbe added a commit that referenced this pull request Nov 6, 2025
@labrenbe
fix: Unit test 'test_validate_ok' (#66)
9beb386 
fix test_validate_ok unit test that was broken on release rc branch
Techassi added a commit that referenced this pull request Nov 6, 2025
@Techassi @labrenbe
chore: Release 25.11.0-rc1 (#65)
1406cbb 
* chore: Release 25.11.0-rc1

Signed-off-by: Techassi <git@techassi.dev>

* fix: Unit test 'test_validate_ok' (#66)

fix test_validate_ok unit test that was broken on release rc branch

---------

Signed-off-by: Techassi <git@techassi.dev>
Co-authored-by: Benedikt Labrenz <benedikt@labrenz.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@labrenbe labrenbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labrenbe @NickLarsenNZ