This repository was archived by the owner on Jul 20, 2022. It is now read-only.
Refactoring, check_labels and spark.port.maxRetries #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted get_master_urls in preparation to add to pod labels to keep track in worker pods which masters are known (in case masters change / scale / delete etc.)
lfrancke
suggested changes
Mar 9, 2021
operator/src/config.rs
Outdated
|
|
||
| /// The worker start command needs to be extended with all known master nodes and ports. | ||
| /// The required URLs are in format: 'spark://<master-node-name>:<master-port' | ||
| /// The required URLs are in format: '<master-node-name>:<master-port' with one time prefix 'spark://' |
Member
There was a problem hiding this comment.
I don't understand what you mean by "one time prefix"?
| labels.get(HASH_LABEL), | ||
| labels.get(TYPE_LABEL), | ||
| labels.get(VERSION_LABEL), | ||
| labels.get(pod_utils::HASH_LABEL), |
Member
There was a problem hiding this comment.
You could use them directly if you want to.
I'll leave it up to do
use pod_utils::HASH_LABEL I mean
operator/src/lib.rs
Outdated
| true | ||
| } | ||
|
|
||
| pub async fn check_worker_master_urls(&self) -> SparkReconcileResult { |
Member
There was a problem hiding this comment.
Could you add a comment what's being checked here?
lfrancke
approved these changes
Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring to prepare unit testing. Added check_labels method for master_url_hash to identify outdated workers (which do not currently have all master urls in their start command).
Added spark.port.maxRetries property to be able to avoid masters/workers/history searching new ports if their respective port is taken by incrementing the port number by 1.