Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Feb 19, 2025

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Feb 19, 2025
@razvan razvan requested a review from a team February 19, 2025 15:45
@razvan razvan enabled auto-merge February 19, 2025 15:45
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that!

@razvan
Copy link
Member Author

razvan commented Feb 20, 2025

Temp close to force cla check re-run.

@razvan razvan closed this Feb 20, 2025
auto-merge was automatically disabled February 20, 2025 09:20

Pull request was closed

@razvan razvan reopened this Feb 20, 2025
@razvan razvan closed this Feb 20, 2025
@razvan razvan reopened this Feb 20, 2025
@razvan razvan added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 087a1ee Feb 21, 2025
49 checks passed
@razvan razvan deleted the fix/custom-images branch February 21, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants