Skip to content

chore!: Migrate from slog to tracing #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 7, 2024
Merged

chore!: Migrate from slog to tracing #40

merged 14 commits into from
May 7, 2024

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Apr 29, 2024 •
edited
Loading

Also bumps all dependencies

@Techassi Techassi self-requested a review April 29, 2024 09:12
Techassi
Techassi reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general approved, but the actions seem to fail.

@nightkr
Copy link
Contributor

nightkr commented Apr 29, 2024

The CI errors seem to be down to the same outdated URL issue that also hit #39.

@sbernauer
Copy link
Member Author

sbernauer commented Apr 29, 2024

@nightkr I actually came here to take a stab at how much effort it would be to go failure -> snafu and decided to quickly bump the deps before :D
Awesome to see that you already started it, happy to review it when needed!

@sbernauer sbernauer requested a review from Techassi April 29, 2024 11:00
@sbernauer sbernauer assigned nightkr and sbernauer and unassigned nightkr Apr 29, 2024
@sbernauer sbernauer requested a review from nightkr April 29, 2024 11:01
@nightkr
Copy link
Contributor

nightkr commented Apr 29, 2024

It should be R4R now.

nightkr
nightkr previously approved these changes Apr 29, 2024
View reviewed changes
Techassi
Techassi reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the CI workflow. Approved again, and I agree with the suggested changes by @nightkr.

@sbernauer
Copy link
Member Author

sbernauer commented Apr 29, 2024

Actually, I reviewed #39, so let's just merge that first, pull in the changes to this branch and then merge this PR

@sbernauer sbernauer changed the title chore: Bump dependencies to latest versions chore!: Migrated from slog to tracing Apr 29, 2024
@sbernauer sbernauer requested review from Techassi and nightkr April 29, 2024 12:50
@sbernauer
Copy link
Member Author

sbernauer commented Apr 29, 2024

Tests are still failing, blocked by the merge of #39

@sbernauer sbernauer changed the title chore!: Migrated from slog to tracing chore!: Migrate from slog to tracing Apr 29, 2024
Techassi
Techassi reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, mostly nitpicks/questions.

@sbernauer sbernauer requested a review from Techassi April 30, 2024 08:29
@sbernauer sbernauer enabled auto-merge May 6, 2024 12:34
@sbernauer sbernauer added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 8127f93 May 7, 2024
@lfrancke lfrancke deleted the chore/bumps branch June 17, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbernauer @nightkr @Techassi