replace NOT IN usage with IN to avoid seq scans

huumn · huumn · commit 1ca5b0e68475 · 2025-12-23T17:40:32.000-06:00
diff --git a/api/payIn/transitions.js b/api/payIn/transitions.js
@@ -1,5 +1,5 @@
 import { datePivot } from '@/lib/time'
-import { Prisma } from '@prisma/client'
+import { Prisma, PayInState } from '@prisma/client'
 import { onBegin, onFail, onPaid, onPaidSideEffects } from '.'
 import { walletLogger } from '@/wallets/server/logger'
 import { getPaymentFailureStatus, getPaymentOrNotSent, hodlInvoiceCltvDetails } from '../lnd'
@@ -9,7 +9,10 @@ import { MIN_SETTLEMENT_CLTV_DELTA } from '@/wallets/server/wrap'
 import { LND_PATHFINDING_TIME_PREF_PPM, LND_PATHFINDING_TIMEOUT_MS } from '@/lib/constants'
 import { notifyWithdrawal } from '@/lib/webPush'
 import { PayInFailureReasonError } from './errors'
+
 export const PAY_IN_TERMINAL_STATES = ['PAID', 'FAILED']
+export const PAY_IN_PENDING_STATES = Object.values(PayInState).filter(state => !PAY_IN_TERMINAL_STATES.includes(state))
+
 const FINALIZE_OPTIONS = { retryLimit: 2 ** 31 - 1, retryBackoff: false, retryDelay: 5, priority: 1000 }
 
 async function transitionPayIn (jobName, data,
diff --git a/worker/payIn.js b/worker/payIn.js
@@ -7,7 +7,8 @@ import { datePivot, sleep } from '@/lib/time'
 import retry from 'async-retry'
 import {
   payInWithdrawalPaid, payInWithdrawalFailed, payInPaid, payInForwarding, payInForwarded, payInFailedForward, payInHeld, payInFailed,
-  PAY_IN_TERMINAL_STATES
+  PAY_IN_TERMINAL_STATES,
+  PAY_IN_PENDING_STATES
 } from '@/api/payIn/transitions'
 import { isWithdrawal } from '@/api/payIn/lib/is'
 import { LND_PATHFINDING_TIMEOUT_MS } from '@/lib/constants'
@@ -292,7 +293,7 @@ export async function checkPendingPayInBolt11s (args) {
   const { models } = args
   const pendingPayIns = await models.payIn.findMany({
     where: {
-      payInState: { notIn: PAY_IN_TERMINAL_STATES },
+      payInState: { in: PAY_IN_PENDING_STATES },
       payInBolt11: { isNot: null }
     },
     include: { payInBolt11: true }
@@ -312,7 +313,7 @@ export async function checkPendingPayOutBolt11s (args) {
   const { models } = args
   const pendingPayOuts = await models.payIn.findMany({
     where: {
-      payInState: { notIn: PAY_IN_TERMINAL_STATES },
+      payInState: { in: PAY_IN_PENDING_STATES },
       payOutBolt11: { isNot: null }
     },
     include: { payOutBolt11: true }
