fix withdrawal notification

huumn · huumn · commit 1eb123976b57 · 2025-11-09T16:05:14.000-06:00
diff --git a/api/payIn/transitions.js b/api/payIn/transitions.js
@@ -182,7 +182,7 @@ export async function payInWithdrawalPaid ({ data, models, ...args }) {
   }, { models, ...args })
 
   if (transitionedPayIn) {
-    await notifyWithdrawal(transitionedPayIn)
+    notifyWithdrawal(transitionedPayIn).catch(console.error)
     const { payOutBolt11 } = transitionedPayIn
     if (payOutBolt11?.protocolId) {
       const { protocolId, userId } = payOutBolt11
diff --git a/lib/webPush.js b/lib/webPush.js
@@ -416,12 +416,14 @@ export async function notifyDeposit (userId, invoice) {
   }
 }
 
-export async function notifyWithdrawal (wdrwl) {
+export async function notifyWithdrawal (payOutBolt11) {
   try {
-    await sendUserNotification(wdrwl.userId, {
-      title: `${numWithUnits(msatsToSats(wdrwl.msatsPaid), { abbreviate: false, unitSingular: 'sat was', unitPlural: 'sats were' })} withdrawn from your account`,
-      setting: 'noteWithdrawals'
-    })
+    if (payOutBolt11.msats > 1000) {
+      await sendUserNotification(payOutBolt11.userId, {
+        title: `${numWithUnits(msatsToSats(payOutBolt11.msats), { abbreviate: false, unitSingular: 'sat was', unitPlural: 'sats were' })} withdrawn from your account`,
+        setting: 'noteWithdrawals'
+      })
+    }
   } catch (err) {
     log('error sending withdrawal notification:', err)
   }

Original file line number	Diff line number	Diff line change
`@@ -416,12 +416,14 @@ export async function notifyDeposit (userId, invoice) {`
`416`	`416`	`}`
`417`	`417`	`}`
`418`	`418`
`419`		`-export async function notifyWithdrawal (wdrwl) {`
	`419`	`+export async function notifyWithdrawal (payOutBolt11) {`
`420`	`420`	`try {`
`421`		`- await sendUserNotification(wdrwl.userId, {`
`422`		- title: `${numWithUnits(msatsToSats(wdrwl.msatsPaid), { abbreviate: false, unitSingular: 'sat was', unitPlural: 'sats were' })} withdrawn from your account`,
`423`		`- setting: 'noteWithdrawals'`
`424`		`- })`
	`421`	`+ if (payOutBolt11.msats > 1000) {`
	`422`	`+ await sendUserNotification(payOutBolt11.userId, {`
	`423`	+ title: `${numWithUnits(msatsToSats(payOutBolt11.msats), { abbreviate: false, unitSingular: 'sat was', unitPlural: 'sats were' })} withdrawn from your account`,
	`424`	`+ setting: 'noteWithdrawals'`
	`425`	`+ })`
	`426`	`+ }`
`425`	`427`	`} catch (err) {`
`426`	`428`	`log('error sending withdrawal notification:', err)`
`427`	`429`	`}`