do not store nostr zap note as scalar

huumn · huumn · commit 30e399126376 · 2025-11-09T16:52:56.000-06:00
diff --git a/api/payIn/types/proxyPayment.js b/api/payIn/types/proxyPayment.js
@@ -42,9 +42,18 @@ export async function getInitial (models, { msats, description, descriptionHash,
 }
 
 export async function onBegin (tx, payInId, { comment, lud18Data, noteStr }) {
+  let note = null
+  if (noteStr) {
+    try {
+      note = JSON.parse(noteStr)
+    } catch (e) {
+      console.error('invalid noteStr', noteStr)
+    }
+  }
+
   const data = {
     ...(lud18Data && { lud18Data: { create: lud18Data } }),
-    ...(noteStr && { nostrNote: { create: { note: noteStr } } }),
+    ...(note && { nostrNote: { create: { note } } }),
     ...(comment && { comment: { create: { comment } } })
   }
 
diff --git a/api/resolvers/notifications.js b/api/resolvers/notifications.js
@@ -219,11 +219,14 @@ export default {
       }
 
       if (meFull.noteDeposits) {
+        // NOTE: for historical reasons we need to join the payInBolt11 table to make sure
+        // the payInBolt11 record exists for the payIn
         queries.push(
           `(SELECT "PayIn".id::text, "PayIn"."payInStateChangedAt" AS "sortTime",
               COALESCE(FLOOR("PayIn"."mcost" / 1000), 0) as "earnedSats",
             'PayInification' AS type
             FROM "PayIn"
+            JOIN "PayInBolt11" ON "PayInBolt11"."payInId" = "PayIn".id
             WHERE "PayIn"."userId" = $1
             AND "PayIn"."payInState" = 'PAID'
             AND "PayIn"."payInStateChangedAt" < $2
