pulp_container_content: Support state=read for container-push repos #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to check whether a tag exists in a container-push repository.
markgoddard
force-pushed
the
read-container-push
branch
from
1044ab2 to
cf828fd
Compare
jovial
previously approved these changes
Feb 9, 2024
jovial
dismissed
their stale review
Code looked good. Didn't see the failing CI.
markgoddard
force-pushed
the
read-container-push
branch
from
1c0daac to
116ad6d
Compare
One of the tests failed: Cannot open /var/lib/pulp/tmp/472@6a279c28a9a3/tmpx7xo368b/tmp0450y_ow-3a0f555ea0e559e403fd0273f0cc10d7ba533c1c8a86d17ab4aa9297c186da78-updateinfo.xml.zst: Cannot detect compression type)
markgoddard
force-pushed
the
read-container-push
branch
from
fa6b247 to
0c7da52
Compare
jovial
previously approved these changes
Feb 9, 2024
Contributor
jovial
left a comment
jovial
left a comment
There was a problem hiding this comment.
Failure looks unrelated to me. Happy for it to be fixed in another PR.
jovial
reviewed
Feb 9, 2024
| mkdir -p settings | ||
|
|
||
| PULP_TAG=${PULP_TAG:-"3.21"} | ||
| PULP_TAG=${PULP_TAG:-"3.45"} |
Contributor
There was a problem hiding this comment.
Hmm, do we need to update this now: https://github.com/stackhpc/ansible-collection-pulp/blob/master/.github/workflows/pull_request.yml#L19-L20?
3.16 fails in some RPM tests.
jovial
approved these changes
Feb 9, 2024
Contributor
jovial
left a comment
jovial
left a comment
There was a problem hiding this comment.
Required checks needs updating for new names
Author
👍 will update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to check whether a tag exists in a container-push repository.