Support virt engine #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the engine and emulator configuration, some level of autodetection is supported - if KVM is supported, this will be used, otherwise QEMU will be used. Much of the logic added here has been adapted from the ironic devstack plugin's tooling.
Machine default is pc-1.0. Perhaps this should be none by default? Mode default is 'host-passthrough' for KVM, 'host-model' otherwise.
markgoddard
commented
Aug 2, 2018
templates/vm.xml.j2
Outdated
| <serial type='pty'/> | ||
| <console type='file'> | ||
| <source path='{{ libvirt_vm_console_log_path }}'/> | ||
| <target type='serial'/> |
Author
There was a problem hiding this comment.
This is probably the main change I'm concerned about as it changes the behaviour from interactive serial console to file logging.
markgoddard
force-pushed
the
support-virt-engine
branch
from
3e886a7 to
da56e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.