Skip to content

Conversation

@jovial
Copy link
Contributor

@jovial jovial commented Feb 2, 2021

The use case is when you want to use a different module system to the one we supply or want to run without one entirely.

The use case is when you want to use a different module system to the
one we supply or want to run without one enitrely.
@jovial jovial requested a review from sjpb February 2, 2021 12:37
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal idea and interface seems fine, approach seems a bit nasty just to deal with omitting one package though as the version-specific vars are already a bit complex.

I suggest just using a conditional in (both) vars files to add an empty string if openhpc_module_system_install is false, then just filtering out empty strings in the yum install step. That's still easily extendable if we want to turn off other packages.

@jovial jovial merged commit 968ab8b into master Feb 3, 2021
@jovial jovial deleted the feature/optional-module-system branch February 3, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants