Add error handling on lookup of user info #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnasiadka
approved these changes
Sep 4, 2025
dougszumski
requested changes
Sep 5, 2025
MoteHue
force-pushed
the
error-handling-on-user-lookup
branch
from
b8356d4 to
fe1ee11
Compare
Without this, the exporter would hang after raising the error:
```
File "radosgw_usage_exporter.py", line 465, in _get_user_info
if "display_name" in user_info:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable
```
MoteHue
force-pushed
the
error-handling-on-user-lookup
branch
from
fe1ee11 to
82508be
Compare
dougszumski
approved these changes
Sep 10, 2025
dougszumski
dismissed
priteau’s stale review
requested change has been made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the exporter would hang after rasing the error: