Add prometheus metrics endpoint #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
reviewed
May 2, 2023
added 6 commits
May 4, 2023 11:59
Switch to using default_registry so that system metrics (cpu time, open file descriptors etc.) are collected too. (Prometheus crate's system metrics feature only works on linux.)
markgoddard
reviewed
May 4, 2023
markgoddard
reviewed
May 4, 2023
|
I'm happy to leave this as non-optional for now, but agree that CLI arg is sensible option if we wanted to do that e.g. for performance reasons |
markgoddard
reviewed
May 4, 2023
markgoddard
reviewed
Jul 10, 2023
Co-authored-by: Mark Goddard <mark@stackhpc.com>
markgoddard
previously approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.