Bump axum, fix trailing slash middleware issue #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
commented
May 2, 2023
markgoddard
commented
- Update MSRV to 1.66.1
- Fix trim trailing slash middleware
- Update axum to 0.6.18
Due to AWS SDK.
The axum docs point out that any middleware that should affect routing must wrap the Router. In 0.6.12 we rely on a bug in axum routing that allows the trailing slash middleware to work on nested paths (but fails on root paths). In 0.6.13 onwards this bug is no longer present, so we lose the trailing slash removal. This change fixes the issue. tokio-rs/axum#1978 https://docs.rs/axum/0.6.18/axum/middleware/index.html#rewriting-request-uri-in-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.