Feature/count header #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we'll also need to update the compliance test suite so that CI continues to pass if we decide to remove the count endpoint. |
|
I suppose the count endpoint might be useful if you only want the count. Otherwise you'd need to request something else and get the count from the header. |
|
Please also update the list of response headers in the README. |
|
Need to also consider how to test this using compliance tests, and more generally how to handle divergence of the API over time. |
markgoddard
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra HTTP header to all successful responses with a count of the number of elements operated on while calculating the result of reduction.
This probably makes the
countendpoint obsolete and worth removing. I can remove that endpoint as part of this PR and bump semver to0.2.0if that's the route we want to take.