Skip to content

Handle S3 AccessDenied Error #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Handle S3 AccessDenied Error #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@ impl From<ActiveStorageError> for ErrorResponse {
Some("NoSuchBucket") => Self::bad_request(&error),

// Unauthorised
Some("InvalidAccessKeyId") | Some("SignatureDoesNotMatch") => {
Self::unauthorised(&error)
}
Some("InvalidAccessKeyId")
| Some("SignatureDoesNotMatch")
| Some("AccessDenied") => Self::unauthorised(&error),

// Internal server error
_ => Self::internal_server_error(&error),
Expand Down Expand Up @@ -415,6 +415,23 @@ mod tests {
test_s3_get_object_error(sdk_error, StatusCode::UNAUTHORIZED, caused_by).await;
}

#[tokio::test]
async fn s3_get_object_access_denied_error() {
// Jump through hoops to create an SdkError.
let smithy_error = SmithyError::builder()
.message("fake smithy error")
.code("AccessDenied")
.build();
let get_object_error = GetObjectError::generic(smithy_error);
let sdk_error = SdkError::service_error(get_object_error, get_smithy_response());
let caused_by = Some(vec![
"service error",
"unhandled error",
"Error { code: \"AccessDenied\", message: \"fake smithy error\" }",
]);
test_s3_get_object_error(sdk_error, StatusCode::UNAUTHORIZED, caused_by).await;
}

#[tokio::test]
async fn s3_byte_stream_error() {
// ByteStreamError provides a From impl for std::io:Error.
Expand Down