Normalise paths, align S3 data, python client #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
commented
Mar 16, 2023
markgoddard
commented
- Explicitly set MSRV in Cargo.toml
- api: Normalise paths to remove trailing slashes
- s3_client: Return data in an 8-byte aligned slice
- Add basic Python client for testing
The data returned by the AWS S3 client does not have any alignment guarantees. In order to reinterpret the data as an array of numbers with a higher alignment than 1, we need to return the data in Bytes object in which the underlying data has a higher alignment. For now we're hard-coding an alignment of 8 bytes, although this should depend on the data type, and potentially whether there are any SIMD requirements. The current method is rather inefficient, involving copying the data at least twice. This is functional, but should be revisited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.