Add Infiniband phyiscal network plugin #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ib_physnet plugin populates the physical_network field of ironic ports determined to be Infiniband ports. Ports with a 'client-id' field in their 'extra' attribute are determined to be IB ports. The plugin is configured via the option [port_physnet] ib_physnet, which is the name of the physical network to apply.
dougszumski
approved these changes
Apr 4, 2018
| :returns: The physical network to set, or None. | ||
| """ | ||
| proc_data = introspection_data['all_interfaces'][iface_name] | ||
| if proc_data.get('client_id'): |
Member
There was a problem hiding this comment.
If this was called something more specific like ib_client_id it might be more obvious to someone not familiar with IB, that it was an IB port but not to worry.
Author
There was a problem hiding this comment.
Yeah this really isn't the best way to identify IB ports. It was added in the original ironic IB spec: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/add-infiniband-support.html
| @@ -0,0 +1,67 @@ | |||
| # Copyright (c) 2017 StackHPC Ltd. | |||
| def test_expected_data_non_ib(self): | ||
| cfg.CONF.set_override('ib_physnet', 'physnet1', | ||
| group='port_physnet') | ||
| self.data['all_interfaces']['em1']['client_id'] = None |
Member
There was a problem hiding this comment.
I suppose we could also try with the client_id key removed, not that the code's broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ib_physnet plugin populates the physical_network field of ironic
ports determined to be Infiniband ports. Ports with a 'client-id' field
in their 'extra' attribute are determined to be IB ports.
The plugin is configured via the option [port_physnet] ib_physnet, which
is the name of the physical network to apply.