Skip to content

Conversation

@priteau
Copy link
Member

@priteau priteau commented Oct 21, 2025

No description provided.

@priteau priteau self-assigned this Oct 21, 2025
@priteau priteau requested a review from a team as a code owner October 21, 2025 10:47
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds documentation on how to resolve a specific warning that may appear after upgrading Ceph to the Squid release. The documentation provides the command to execute to resolve the warning. I have added a review comment to address a potential typo.

Alex-Welsh
Alex-Welsh previously approved these changes Oct 21, 2025
@priteau
Copy link
Member Author

priteau commented Oct 21, 2025

/gemini Can you describe the typo you found?

@gemini-code-assist
Copy link

It seems there might be a misunderstanding. I haven't performed a code review on this pull request yet, so I haven't identified any typos. If you would like me to review the pull request for potential issues, including typos, please use the /gemini review command.

@priteau
Copy link
Member Author

priteau commented Oct 21, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an important documentation note for operators upgrading to Ceph Squid. It explains how to resolve a common warning about require_osd_release. My review includes a suggestion to rephrase the instruction for verifying OSD versions to make it clearer and emphasize its importance, thus reducing the risk of user error during the upgrade process.

@priteau priteau force-pushed the ceph-squid-upgrade branch from 5b5e1b6 to 22aef4e Compare October 21, 2025 11:59
@priteau priteau merged commit 2a9f584 into stackhpc/2025.1 Oct 21, 2025
5 checks passed
@priteau priteau deleted the ceph-squid-upgrade branch October 21, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants