Skip to content

Conversation

@priteau
Copy link
Member

@priteau priteau commented Oct 21, 2025

No description provided.

@priteau priteau self-assigned this Oct 21, 2025
@priteau priteau requested a review from a team as a code owner October 21, 2025 12:07
@priteau priteau merged commit 28e5b3c into stackhpc/2025.1 Oct 21, 2025
5 checks passed
@priteau priteau deleted the ceph-squid-upgrade branch October 21, 2025 12:07
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue with reStructuredText markup in the Ceph upgrade documentation. I have added one comment suggesting an improvement to maintain stylistic consistency throughout the file. The proposed change is a good step towards improving the overall quality of the documentation.

Comment on lines +155 to +156
To resolve this, first verify that all OSDs were upgraded to Squid with ``ceph
versions``. Once confirmed, run the following command:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly updates the markup for ceph versions to use double backticks, which is the standard for inline literals in reStructuredText. However, this introduces a stylistic inconsistency, as other commands in this file (e.g., ceph -s on line 149) still use single backticks. To ensure consistent formatting throughout the document, please consider updating all inline command references to use double backticks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants