Skip to content

Conversation

@chouroukblizzard
Copy link

@chouroukblizzard chouroukblizzard commented Oct 29, 2025

Bump nova image tag to resolve this bug: https://bugs.launchpad.net/nova/+bug/2098892
Fix stackhpc/nova@458b443 included in this PR: stackhpc/nova#158

@chouroukblizzard chouroukblizzard requested a review from a team as a code owner October 29, 2025 08:54
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kolla image tags for the nova service, likely to address bug 2091033 as per the release notes. The change is straightforward, but the pull request description lacks this context, which would be helpful for reviewers. My main concern is the limited scope of the update. Several other services are still using the old image tag, which may lack recent security fixes, such as the one for CVE-2024-36039. I have recommended extending the update to all relevant services to maintain a consistent security posture.

Copy link
Member

@mnasiadka mnasiadka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we need more details in commit message

@chouroukblizzard chouroukblizzard force-pushed the update-nova-tag-20250321T110513 branch from 1bd1255 to b8f4188 Compare October 29, 2025 09:07
This fixes a nova-compute issue seen with VGPU, as well as other bugs:

    TypeError: virNodeDeviceLookupByName() argument 2 must be str or None, not Proxy

Co-authored-by: Pierre Riteau <pierre@stackhpc.com>
@priteau priteau force-pushed the update-nova-tag-20250321T110513 branch from b8f4188 to e98e732 Compare October 29, 2025 11:46
@priteau priteau changed the title Update kolla-image-tags.yml Bump Nova container images to fix LP#2098892 Oct 29, 2025
@priteau priteau requested a review from mnasiadka October 29, 2025 11:47
@priteau priteau enabled auto-merge October 30, 2025 06:34
@dougszumski dougszumski dismissed mnasiadka’s stale review October 30, 2025 16:10

The commit message was improved to be more descriptive.

@priteau priteau merged commit 50d18cd into stackhpc/2023.1 Oct 30, 2025
12 checks passed
@priteau priteau deleted the update-nova-tag-20250321T110513 branch October 30, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants