Skip to content

Conversation

@dougszumski
Copy link
Member

@dougszumski dougszumski requested a review from a team as a code owner November 13, 2025 13:34
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces basic support for Dell SONiC switches by adding a new release note entry. It also updates the Kolla image tags for the neutron service across different operating system distributions. The changes appear to be straightforward and correctly implemented, aligning with the stated purpose of the pull request. No issues of medium, high, or critical severity were identified in the code changes.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is there an equivalent patch for 2025.1? I'm a bit concerned we'll forget about it, upgrade, and break things

@dougszumski dougszumski merged commit 2a1283f into stackhpc/2024.1 Nov 14, 2025
23 checks passed
@dougszumski dougszumski deleted the feature/GT-1561-dell-sonic branch November 14, 2025 10:45
@dougszumski
Copy link
Member Author

LGTM but is there an equivalent patch for 2025.1? I'm a bit concerned we'll forget about it, upgrade, and break things

Thanks Alex - I am trying to attack it from the other side for later releases since there is a Dell Sonic driver upstream. I'll leave the ticket open until I've resolved it one way or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants