OVN fix chassis priorities backport to 2024.1 #1983
Merged
+134
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now aligning the HA chassis priorities based on gateway chassis ones. Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com> (cherry picked from commit 2be3fd2)
(cherry picked from commit e46c18c)
After kolla-ansible patch [1] ovn commands can run on all nodes. Changing method of getting the leader. [1] https://review.opendev.org/c/openstack/kolla-ansible/+/963412 Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com> (cherry picked from commit f8f9b24)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the ovn-fix-chassis-priorities.yml playbook. It introduces a more reliable method for detecting the OVN northbound database leader and replaces the simplistic priority assignment with a sophisticated logic that correctly aligns HA chassis priorities with active gateways. These changes should effectively address the routing issues caused by misaligned priorities. My review includes a few suggestions to enhance the maintainability and efficiency of the embedded shell script.
mnasiadka
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.