Rephrase the match logic for interfaces monitored for package drops #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OVS bridge interfaces drop packets during normal operation. Change the regex to filter out interfaces that don't matter for packet drops.
dougszumski
approved these changes
Nov 10, 2022
cityofships
reviewed
Nov 14, 2022
| # alert on nic packet errors and drops rates > 1 packet/s | ||
| - alert: NetworkPacketsDropped | ||
| expr: irate(node_network_receive_drop_total{device=~"en.*|eth.*"}[5m]) + irate(node_network_transmit_drop_total{device=~"en.*|eth.*"}[5m]) > 1 | ||
| expr: irate(node_network_receive_drop_total{device!~"lo|br.*|.*-ovs|tap.*"}[5m]) + irate(node_network_transmit_drop_total{device!~"lo|br.*|.*-ovs|tap.*"}[5m]) > 1 |
There was a problem hiding this comment.
This will catch, among others:
bond.*
docker0
genev_sys_6081
ovs-system
p-brbond.*
qbr.*
qvb.*
vxlan_sys_4789
The previous regex has already been filtering out OVS bridges - I thought we were only expanding it with |bond.*.
Does by the way |ib.* make sense too?
There was a problem hiding this comment.
Perhaps this needs to be addressed. Could be a follow up?
|
Backported to Xena: #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVS bridge interfaces drop packets during normal operation, generating lots of spurious alerts. Change the regex to filter out interfaces that don't matter for packet drops.