Skip to content

Fix smartmon script #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix smartmon script #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion etc/kayobe/ansible/scripts/smartmon.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ parse_smartctl_scsi_attributes() {
}

parse_smartctl_info() {
shopt -s nocasematch
local -i smart_available=0 smart_enabled=0 smart_healthy=
local disk="$1" disk_type="$2"
local model_family='' device_model='' serial_number='' fw_version='' vendor='' product='' revision='' lun_id=''
Expand Down Expand Up @@ -199,4 +200,4 @@ for device in ${device_list}; do
exit
;;
esac
done | format_output
done | format_output
9 changes: 9 additions & 0 deletions releasenotes/notes/fix-smartmon-script-db2a38df1b245e58.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
fixes:
- |
Fixes the smartmon script to be case insensitive when checking for
the inital SMART info. This is to ensure that the script works
correctly on systems where the output of `smartctl -i` is not
capitalised as previously expected by the script. This leads to
badly formatted .prom files which lead to node_exporter failing to
scrape the file.