Skip to content

Conversation

@sjpb
Copy link
Contributor

@sjpb sjpb commented Sep 19, 2025

No description provided.

@sjpb sjpb requested a review from a team as a code owner September 19, 2025 11:29
@sjpb sjpb marked this pull request as draft September 19, 2025 11:29
@gemini-code-assist
Copy link

Summary of Changes

Hello @sjpb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the software availability for Slurm appliances by introducing several new RPM package repositories. The additions include Open OnDemand for web-based access to High-Performance Computing (HPC) resources, the Cisco OpenH264 codec for improved multimedia handling, and TurboVNC for robust remote desktop solutions. These changes broaden the range of tools and functionalities accessible within the Slurm environment, supporting a more versatile and capable system.

Highlights

  • Open OnDemand Repositories: Added configurations for the Open OnDemand Web Repository for both Enterprise Linux 8 (EL8) and Enterprise Linux 9 (EL9) distributions.
  • EPEL 9 Cisco OpenH264: Included the Extra Packages for Enterprise Linux 9 Cisco OpenH264 repository to provide multimedia codec support.
  • TurboVNC Repositories: Integrated the TurboVNC and TurboVNC source repositories, enabling remote desktop capabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new RPM package repositories to the package-repos configuration file, including repositories for Open OnDemand, EPEL 9 Cisco OpenH264, and TurboVNC. The changes are generally well-structured and consistent with the existing file format. I have identified one issue where a sync_group is missing for one of the new repositories, which would likely cause a validation failure. I've provided a suggestion to fix this.

@sjpb sjpb force-pushed the add/missing-slurm-repos branch from b9d392e to acd3aa0 Compare September 24, 2025 13:55
@sjpb sjpb requested a review from Alex-Welsh September 24, 2025 15:28
@sjpb sjpb force-pushed the add/missing-slurm-repos branch from cf253a1 to 6eebfc7 Compare September 24, 2025 15:30
@sjpb sjpb requested a review from priteau September 25, 2025 09:21
@sjpb sjpb requested a review from Alex-Welsh September 25, 2025 12:04
@seunghun1ee
Copy link
Member

@Alex-Welsh Alex-Welsh merged commit 7b0b12c into main Sep 25, 2025
5 checks passed
@Alex-Welsh Alex-Welsh deleted the add/missing-slurm-repos branch September 25, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants