-
Notifications
You must be signed in to change notification settings - Fork 1
Add Rocky Linux 9.7, DOCA 3.2.0 repos, add sources #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @elelaysh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the repository configurations to integrate Rocky Linux 9.7, replacing the older 9.6 versions which are now marked as deprecated. Additionally, it expands the available source repositories by including HighAvailability for 9.7 and the SIG Security Common for Rocky Linux 9, ensuring comprehensive package management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Rocky Linux repositories from version 9.6 to 9.7, moves the 9.6 repositories to the deprecated list, and adds new source repositories for HighAvailability and SIG Security. The changes are mostly correct, but I've found a path inconsistency for the HighAvailability repositories that could cause synchronization to fail. I've provided suggestions to fix this in both the active and deprecated repository files.
sources added: HighAvailability and SIG security common
cd078dd to
93c365a
Compare
|
Repository synced |
|
The inconsistency with upstream camel-cased HighAvailability is noted, but I keep the same lowercased highavailability as previous versions for internal consistency. |
|
@elelaysh could you also add DOCA 3.2.0 as well? |
|
DOCA 2.9.3 is an LTS so there might be new packages in the future. It is currently in use by the Slurm appliance. Do we want to keep synchronising it? |
Lets leave it in for now and remove it once we get confirmation it's no longer needed in Slurm land |
b348e74 to
c34f727
Compare
Indeed, I've moved it back to package-repos |
Uh oh!
There was an error while loading. Please reload this page.