Skip to content

Conversation

@cgoetz-inovex
Copy link
Contributor

@cgoetz-inovex cgoetz-inovex commented Nov 21, 2025

Description

relates to STACKITCLI-288

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner November 21, 2025 16:00
@cgoetz-inovex cgoetz-inovex enabled auto-merge (squash) November 25, 2025 13:46
@cgoetz-inovex cgoetz-inovex merged commit c573f95 into main Nov 25, 2025
5 checks passed
@cgoetz-inovex cgoetz-inovex deleted the feat/STACKITCLI-288-kms-describe branch November 25, 2025 13:52
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/key 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/key/describe 76.79% (+76.79%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/keyring 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/keyring/describe 65.79% (+65.79%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/wrappingkey 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/wrappingkey/describe 76.79% (+76.79%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/key/describe/describe.go 76.79% (+76.79%) 56 (+56) 43 (+43) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/key/key.go 0.00% (ø) 10 (+1) 0 10 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/keyring/describe/describe.go 65.79% (+65.79%) 38 (+38) 25 (+25) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/keyring/keyring.go 0.00% (ø) 7 (+1) 0 7 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/wrappingkey/describe/describe.go 76.79% (+76.79%) 56 (+56) 43 (+43) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/wrappingkey/wrappingkey.go 0.00% (ø) 7 (+1) 0 7 (+1)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/key/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/keyring/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/kms/wrappingkey/describe/describe_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants