Feat/stackitcli 184 onboarding alb credentials #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahkauv70
force-pushed
the
feat/stackitcli-184-onboarding-alb-credentials
branch
6 times, most recently
from
59ea6be to
05c82eb
Compare
bahkauv70
changed the base branch from
main
to
feat/stackitcli-134-onboading-alb-service
bahkauv70
force-pushed
the
feat/stackitcli-184-onboarding-alb-credentials
branch
from
05c82eb to
fb4152b
Compare
bahkauv70
requested review from
Fyusel,
marceljk and
rubenhoenle
as code owners
bahkauv70
force-pushed
the
feat/stackitcli-184-onboarding-alb-credentials
branch
from
fb4152b to
83ad667
Compare
marceljk
reviewed
Apr 14, 2025
bahkauv70
force-pushed
the
feat/stackitcli-184-onboarding-alb-credentials
branch
3 times, most recently
from
934b1a3 to
b8040da
Compare
marceljk
reviewed
Apr 14, 2025
bahkauv70
force-pushed
the
feat/stackitcli-184-onboarding-alb-credentials
branch
from
0229cf7 to
3d59f50
Compare
bahkauv70
force-pushed
the
feat/stackitcli-134-onboading-alb-service
branch
from
c71a875 to
4080d5a
Compare
marceljk
approved these changes
Apr 14, 2025
* feat(credentials) * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * feat(alb project): support for quota and plans * feat(alb project): updated documentation * feat(alb project): review findings
bahkauv70
force-pushed
the
feat/stackitcli-184-onboarding-alb-credentials
branch
from
3d59f50 to
4c6537c
Compare
bahkauv70
merged commit 0eebe64
into
feat/stackitcli-134-onboading-alb-service
3 checks passed
bahkauv70
added a commit
that referenced
this pull request
Apr 14, 2025
* feat(alb): list command * feat(alb): bugfix * feat(alb): add template support * feat(alb): create command * feat(alb): fix testcases * feat(alb): add update * feat(alb): add describe command * feat(alb): delete command * feat(alb): fix linter issues * feat(alb): code cleanup * feat(alb): template support for pool * feat(alb): added target pool update * feat(alb): add list of errors to describe output * feat(alb): Include number of errors * feat(alb): retrieve the existing loadbalancer config to evaluate the current version * feat(alb): switch source of templates to yaml to allow comments * feat(alb): corrected template for target pool * feat(alb): retrieve target pool name from configuration file * feat(alb): updated documentation * feat(alb): add missing delete confirmation * feat(alb): review findings * Feat/stackitcli 184 onboarding alb credentials (#696) * feat(credentials): list command * feat(credentials): commands working * feat(credentials): corrected chaining of commands * feat(credentials): fixed linter issues * feat(credentials): command implementation * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * Feat/stackitcli 183 onboarding alb project api (#700) * feat(credentials) * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * feat(alb project): support for quota and plans * feat(alb project): updated documentation * feat(alb project): review findings * feat(credentials): Integrated review findings * feat(credentials): more review findings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrating the load balancer API from PR134 with the observability features requires the creation and management of credentials. Building on #697 this PR provides the standard CRUD operations for credentials.
⚠️ Mind the non-standard target branch!
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)