Skip to content

feat: Allow managing server state in stackit_server resource #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 15, 2025
Merged

feat: Allow managing server state in stackit_server resource #623

merged 10 commits into from
Jan 15, 2025

Conversation

@bahkauv70
Copy link
Contributor

No description provided.

@bahkauv70 bahkauv70 force-pushed the feat/stackittpr-43-IaaS-Server-desired-status branch from e9bc85a to 4cfb720 Compare January 8, 2025 10:14
@bahkauv70 bahkauv70 force-pushed the feat/stackittpr-43-IaaS-Server-desired-status branch 2 times, most recently from 76cebb9 to cc39e4a Compare January 8, 2025 11:51
@bahkauv70 bahkauv70 force-pushed the feat/stackittpr-43-IaaS-Server-desired-status branch from cc39e4a to c4e46e6 Compare January 8, 2025 12:02
@bahkauv70 bahkauv70 marked this pull request as ready for review January 8, 2025 12:09
marceljk
marceljk reviewed Jan 8, 2025
View reviewed changes
vicentepinto98
vicentepinto98 reviewed Jan 8, 2025
View reviewed changes
@bahkauv70
Copy link
Contributor Author

Regarding the waiters: The retrieval of the server state is the only situation where a waiter is not used. However, function waiter.CreateServerWaitHandler cannot be used, as it explicitly blocks until the server state becomes ACTIVE. By principle this won't not work for us, as the provider must be able to retrieve the server attributes in any state

vicentepinto98
vicentepinto98 previously approved these changes Jan 9, 2025
View reviewed changes
@vicentepinto98 vicentepinto98 dismissed their stale review January 9, 2025 11:52

update field description

@bahkauv70 bahkauv70 changed the title feat: implemented state switching in resource feat: Allow managing server state in stackit_server resource Jan 9, 2025
@bahkauv70 bahkauv70 merged commit f04ced9 into main Jan 15, 2025
3 checks passed
@bahkauv70 bahkauv70 deleted the feat/stackittpr-43-IaaS-Server-desired-status branch January 15, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marceljk marceljk marceljk approved these changes

+1 more reviewer

@vicentepinto98 vicentepinto98 vicentepinto98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bahkauv70 @vicentepinto98 @marceljk