Skip to content

Commit a31972b

Browse files
github-actions[bot]Radoslav Dimitrov
andcommitted
Docs-review fixes on v0.23.1 release docs
- migrate-to-v1beta1.mdx: replace the kubectl --raw API discovery command with a jq query over CRD status.storedVersions, which actually identifies CRDs still holding v1alpha1-stored resources (the previous command only listed kinds served at v1alpha1, always all of them). - auth-k8s.mdx: smooth out the awkward leading-ellipsis sentence in the "Default callback URL for upstream providers" section by merging it into the preceding sentence and dropping the parenthetical em-dash-like aside in favor of a natural "for example" clause. Co-authored-by: Radoslav Dimitrov <undefined@users.noreply.github.com>
1 parent 5d734ad commit a31972b

2 files changed

Lines changed: 12 additions & 10 deletions

File tree

docs/toolhive/guides-k8s/auth-k8s.mdx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -811,7 +811,8 @@ spec:
811811
resourceUrl: 'https://mcp.example.com/mcp'
812812
```
813813

814-
Omitting `redirectUri` on the upstream provider:
814+
Omitting `redirectUri` on the upstream provider resolves the callback to
815+
`https://mcp.example.com/mcp/oauth/callback`:
815816

816817
```yaml
817818
upstreamProviders:
@@ -827,11 +828,10 @@ upstreamProviders:
827828
# https://mcp.example.com/mcp/oauth/callback
828829
```
829830

830-
...resolves to `https://mcp.example.com/mcp/oauth/callback`. Set
831-
`redirectUri` explicitly if you need a non-default callback path (for example,
832-
to route the callback through a separate gateway hostname). If `resourceUrl`
833-
is also unset, no default is applied and the upstream provider must have
834-
`redirectUri` set explicitly.
831+
Set `redirectUri` explicitly if you need a non-default callback path, for
832+
example to route the callback through a separate gateway hostname. If
833+
`resourceUrl` is also unset, no default is applied and the upstream provider
834+
must have `redirectUri` set explicitly.
835835

836836
## Set up authorization
837837

docs/toolhive/guides-k8s/migrate-to-v1beta1.mdx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -767,12 +767,14 @@ To find remaining `v1alpha1` manifests in a Git repository:
767767
grep -rn 'toolhive.stacklok.dev/v1alpha1' .
768768
```
769769

770-
To find `v1alpha1` resources already in the cluster and identify which kinds
771-
still need re-applying:
770+
To check which CRDs still list `v1alpha1` in `status.storedVersions` (these
771+
have at least one stored resource that has not yet been re-applied at
772+
`v1beta1`):
772773

773774
```bash
774-
kubectl get -A --raw \
775-
"/apis/toolhive.stacklok.dev/v1alpha1" | jq '.resources[].name'
775+
kubectl get crds -o json | jq -r '.items[]
776+
| select(.spec.group == "toolhive.stacklok.dev")
777+
| "\(.metadata.name): \(.status.storedVersions)"'
776778
```
777779

778780
## Next steps

0 commit comments

Comments
 (0)