Skip to content

Conversation

@peppescg
Copy link
Collaborator

Kapture.2025-11-17.at.16.53.45.mp4

@peppescg peppescg self-assigned this Nov 17, 2025
Copilot AI review requested due to automatic review settings November 17, 2025 15:55
Copilot finished reviewing on behalf of peppescg November 17, 2025 15:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new signin page at /signin to replace the old /sign-in route, featuring an improved UI with the Toolhive branding and Okta SSO integration. The changes modernize the authentication flow with toast notifications and a reusable sign-out component.

Key changes:

  • Migrated signin route from /sign-in to /signin with updated redirects across the application
  • Added toast notifications via sonner library for better user feedback on authentication errors
  • Created a new SignOut component for consistent sign-out functionality across pages

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/lib/auth-client.ts Updated default redirect URI from /sign-in to /signin and comment references
src/components/sign-out-button.tsx New reusable sign-out button component with loading states
src/app/signin/page.tsx New signin page with improved UI, Toolhive branding, and error toast notifications
src/app/sign-in/page.tsx Removed old signin page implementation
src/app/page.tsx Converted to server-side rendering with redirect to /signin for unauthenticated users
src/app/layout.tsx Added Toaster component for application-wide toast notifications
src/app/catalogue/page.tsx Updated redirect from /sign-in to /signin
src/app/catalog/page.tsx New catalog page using server-side rendering with SignOut component
public/toolhive-icon.svg Added Toolhive logo icon for branding
public/okta-icon.svg Added Okta icon for SSO button
package.json & pnpm-lock.yaml Added sonner dependency (v2.0.7) for toast notifications
dev-auth/oidc-provider.mjs Fixed environment variable name from OIDC_ISSUER_URL to OIDC_ISSUER
dev-auth/README.md Updated documentation to reference correct OIDC_ISSUER variable name
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@peppescg peppescg linked an issue Nov 17, 2025 that may be closed by this pull request
@peppescg peppescg merged commit 30a745f into main Nov 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Sign in page

3 participants