-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add signin page #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new signin page at /signin to replace the old /sign-in route, featuring an improved UI with the Toolhive branding and Okta SSO integration. The changes modernize the authentication flow with toast notifications and a reusable sign-out component.
Key changes:
- Migrated signin route from
/sign-into/signinwith updated redirects across the application - Added toast notifications via sonner library for better user feedback on authentication errors
- Created a new
SignOutcomponent for consistent sign-out functionality across pages
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/lib/auth-client.ts |
Updated default redirect URI from /sign-in to /signin and comment references |
src/components/sign-out-button.tsx |
New reusable sign-out button component with loading states |
src/app/signin/page.tsx |
New signin page with improved UI, Toolhive branding, and error toast notifications |
src/app/sign-in/page.tsx |
Removed old signin page implementation |
src/app/page.tsx |
Converted to server-side rendering with redirect to /signin for unauthenticated users |
src/app/layout.tsx |
Added Toaster component for application-wide toast notifications |
src/app/catalogue/page.tsx |
Updated redirect from /sign-in to /signin |
src/app/catalog/page.tsx |
New catalog page using server-side rendering with SignOut component |
public/toolhive-icon.svg |
Added Toolhive logo icon for branding |
public/okta-icon.svg |
Added Okta icon for SSO button |
package.json & pnpm-lock.yaml |
Added sonner dependency (v2.0.7) for toast notifications |
dev-auth/oidc-provider.mjs |
Fixed environment variable name from OIDC_ISSUER_URL to OIDC_ISSUER |
dev-auth/README.md |
Updated documentation to reference correct OIDC_ISSUER variable name |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kapture.2025-11-17.at.16.53.45.mp4