-
Notifications
You must be signed in to change notification settings - Fork 4
Add authentication configuration types #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add AuthConfig and OAuthProviderConfig to support multi-provider OAuth authentication. The configuration supports: - Two modes: anonymous (default) and oauth - Multiple OAuth providers for K8s service accounts and external IDPs - File-based client secrets with secure path validation - IssuerURL validation with HTTPS enforcement - Required audience claim per RFC 6749 Set THV_REGISTRY_INSECURE_URL=true to allow HTTP issuers for development.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 67.26% 67.69% +0.43%
==========================================
Files 53 53
Lines 3009 3068 +59
==========================================
+ Hits 2024 2077 +53
- Misses 853 857 +4
- Partials 132 134 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rdimitrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
|
fwiw, this is what my local config looks like: |
Add AuthConfig and OAuthProviderConfig to support multi-provider OAuth authentication. The configuration supports:
Set THV_REGISTRY_INSECURE_URL=true to allow HTTP issuers for development.