Skip to content

Conversation

@ChrisJBurns
Copy link
Collaborator

To avoid breaking changes in local setups which by default will export metrics, we want to enable the metrics and tracing exporters by default. Now if the otel-endpoint is provided, toolhive will attempt to export the metrics and traces.

We will leave the defaults for Kubernetes to disabled, this is because this is a new capability so there is no breaking changes here.

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns enabled auto-merge (squash) September 9, 2025 12:16
@ChrisJBurns ChrisJBurns merged commit 2ac9654 into main Sep 9, 2025
15 of 16 checks passed
@ChrisJBurns ChrisJBurns deleted the otel-defaults branch September 9, 2025 12:16
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.29%. Comparing base (c9011cf) to head (6261c93).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
+ Coverage   41.20%   41.29%   +0.08%     
==========================================
  Files         184      184              
  Lines       21478    21478              
==========================================
+ Hits         8851     8870      +19     
+ Misses      11955    11933      -22     
- Partials      672      675       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 38.447% (+0.07%) from 38.373%
when pulling 6261c93 on otel-defaults
into c9011cf on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants