Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Sep 11, 2025

Following on from yesterday's changes, we can encounter situations where the container is looked up using the workload name instead of the container name. If we cannot find the container by workload name, attempt to find a container with the workload name set in the labels.

Following on from yesterday's changes, we can encounter situations where
the container is looked up using the workload name instead of the
container name. If we cannot find the container by workload name,
attempt to find a container with the workload name set in the labels.
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.55%. Comparing base (85c1422) to head (cdce6d0).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/container/docker/client.go 0.00% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
- Coverage   42.73%   42.55%   -0.18%     
==========================================
  Files         184      184              
  Lines       21852    21893      +41     
==========================================
- Hits         9338     9317      -21     
- Misses      11798    11862      +64     
+ Partials      716      714       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2025

Coverage Status

coverage: 39.911% (-0.06%) from 39.97%
when pulling cdce6d0 on state-management-bug
into 0a12262 on main.

ChrisJBurns
ChrisJBurns previously approved these changes Sep 11, 2025
Copy link
Contributor

@amirejaz amirejaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@dmjb dmjb merged commit 16d75ce into main Sep 11, 2025
29 of 32 checks passed
@dmjb dmjb deleted the state-management-bug branch September 11, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants