Skip to content

Conversation

@jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 11, 2025

Implements a standalone HTTP API server for accessing ToolHive registry data and deployed MCP server information in Kubernetes environments.

Features:
- RESTful API for registry metadata and server discovery
- MCP Registry API v0 compatibility (/v0/servers, /v0/publish endpoints)
- Separate Taskfile for registry API build and documentation tasks
- Health check, readiness, and version endpoints
- Structured logging and error handling

Fixes: #1745

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 36.71679% with 505 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.42%. Comparing base (f2b6bc3) to head (bd86df9).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
cmd/thv-registry-api/app/serve.go 0.00% 105 Missing ⚠️
.../thv-registry-api/internal/service/k8s_provider.go 0.00% 86 Missing ⚠️
cmd/thv-registry-api/api/v1/routes.go 63.43% 69 Missing and 14 partials ⚠️
...egistry-api/internal/service/mocks/mock_service.go 0.00% 60 Missing ⚠️
pkg/container/kubernetes/namespace.go 0.00% 51 Missing ⚠️
...gistry-api/internal/service/mocks/mock_provider.go 0.00% 47 Missing ⚠️
cmd/thv-registry-api/app/commands.go 0.00% 24 Missing ⚠️
cmd/thv-registry-api/internal/service/service.go 82.73% 18 Missing and 6 partials ⚠️
cmd/thv-registry-api/api/v1/server.go 69.38% 15 Missing ⚠️
cmd/thv-registry-api/main.go 0.00% 7 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
- Coverage   44.59%   44.42%   -0.17%     
==========================================
  Files         203      214      +11     
  Lines       25864    26613     +749     
==========================================
+ Hits        11534    11823     +289     
- Misses      13428    13867     +439     
- Partials      902      923      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2025

Coverage Status

coverage: 41.118% (+1.0%) from 40.083%
when pulling abab72b on thv-registry-api
into b640a5f on main.

Copy link
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm apart from minor comments

@jhrozek
Copy link
Contributor Author

jhrozek commented Sep 14, 2025

/lgtm apart from minor comments

Thank you very much for the review, I addressed your comments in separate patches for easier review (we squash them during merge anyway).

I will see about getting you review privileges to not slow us down but in the meantime, I might need to get someone to rubber-stamp the PR once you verify your comments have been resolved.

Copy link
Contributor

@yrobla yrobla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a pair of comments. requesting changes because of the confusing messages when configmap does not exist

…ry data and deployed MCP server information in Kubernetes environments.

Features:
- RESTful API for registry metadata and server discovery
- MCP Registry API v0 compatibility (/v0/servers, /v0/publish endpoints)
- Separate Taskfile for registry API build and documentation tasks
- Health check, readiness, and version endpoints
- Structured logging and error handling

Fixes: #1745
@jhrozek
Copy link
Contributor Author

jhrozek commented Sep 15, 2025

i added a pair of comments. requesting changes because of the confusing messages when configmap does not exist

Thank you for the review, nice catches, please see the new patches (I added individual patches for easier review)

Copy link
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhrozek
Copy link
Contributor Author

jhrozek commented Sep 15, 2025

@yrobla let me know if the latest push fixed the comments you had 😄

@jhrozek jhrozek merged commit 8396023 into main Sep 16, 2025
18 of 19 checks passed
@jhrozek jhrozek deleted the thv-registry-api branch September 16, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Kubernetes MCPRegistry] Registry API service

5 participants