-
Notifications
You must be signed in to change notification settings - Fork 156
Add the thv-registry-api binary #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
73ad5c3 to
3c1f3c4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 44.59% 44.42% -0.17%
==========================================
Files 203 214 +11
Lines 25864 26613 +749
==========================================
+ Hits 11534 11823 +289
- Misses 13428 13867 +439
- Partials 902 923 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3c1f3c4 to
a03daa3
Compare
dmartinol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm apart from minor comments
Thank you very much for the review, I addressed your comments in separate patches for easier review (we squash them during merge anyway). I will see about getting you review privileges to not slow us down but in the meantime, I might need to get someone to rubber-stamp the PR once you verify your comments have been resolved. |
abab72b to
f5b9473
Compare
yrobla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added a pair of comments. requesting changes because of the confusing messages when configmap does not exist
…ry data and deployed MCP server information in Kubernetes environments. Features: - RESTful API for registry metadata and server discovery - MCP Registry API v0 compatibility (/v0/servers, /v0/publish endpoints) - Separate Taskfile for registry API build and documentation tasks - Health check, readiness, and version endpoints - Structured logging and error handling Fixes: #1745
f5b9473 to
bd86df9
Compare
Thank you for the review, nice catches, please see the new patches (I added individual patches for easier review) |
dmartinol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@yrobla let me know if the latest push fixed the comments you had 😄 |
Implements a standalone HTTP API server for accessing ToolHive registry data and deployed MCP server information in Kubernetes environments.
Features:
- RESTful API for registry metadata and server discovery
- MCP Registry API v0 compatibility (/v0/servers, /v0/publish endpoints)
- Separate Taskfile for registry API build and documentation tasks
- Health check, readiness, and version endpoints
- Structured logging and error handling
Fixes: #1745