-
Notifications
You must be signed in to change notification settings - Fork 133
Move CRDs from templates/ to crds/ directory #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CRDs from templates/ to crds/ directory #1915
Conversation
- Move CRD YAML files from templates/ to crds/ directory - This follows Helm best practices where CRDs in crds/ directory are automatically installed - CRDs will be available during validation time for other charts - No functional changes to the CRDs themselves Files moved: - toolhive.stacklok.dev_mcpregistries.yaml - toolhive.stacklok.dev_mcpservers.yaml - toolhive.stacklok.dev_mcptoolconfigs.yaml
|
I tend to agree with the change but the real change must be in the operator-manifests task to generate the files in the new destination folder. Apart of that, I see also changes needed in the CI workflow to adapt to the new file structure. |
|
Thanks for this @lokeshrangineni, good spot! As @dmartinol mentioned, you'll need to update the relevant automated places where those are generated so that they're generated in the right place |
…e crds directory rather than in templates directory to follow the helm standards.
@dmartinol Thank you for the feedback. I have incorporated the review comments also searched across the repo for cc: @ChrisJBurns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm!
|
@lokeshrangineni I believe the Chart will need a bump |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
+ Coverage 46.71% 46.75% +0.03%
==========================================
Files 220 220
Lines 27378 27378
==========================================
+ Hits 12791 12801 +10
+ Misses 13615 13599 -16
- Partials 972 978 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have bumped the chart release from 0.0.25 to 0.0.26. PTAL. |
|
Thanks @lokeshrangineni |
Files moved:
This fixes the issue reported - #1914