Skip to content

Conversation

@lokeshrangineni
Copy link
Contributor

  • Move CRD YAML files from templates/ to crds/ directory
  • This follows Helm best practices where CRDs in crds/ directory are automatically installed
  • CRDs will be available during validation time for other charts
  • No functional changes to the CRDs themselves

Files moved:

  • toolhive.stacklok.dev_mcpregistries.yaml
  • toolhive.stacklok.dev_mcpservers.yaml
  • toolhive.stacklok.dev_mcptoolconfigs.yaml

This fixes the issue reported - #1914

- Move CRD YAML files from templates/ to crds/ directory
- This follows Helm best practices where CRDs in crds/ directory are automatically installed
- CRDs will be available during validation time for other charts
- No functional changes to the CRDs themselves

Files moved:
- toolhive.stacklok.dev_mcpregistries.yaml
- toolhive.stacklok.dev_mcpservers.yaml
- toolhive.stacklok.dev_mcptoolconfigs.yaml
@dmartinol
Copy link
Collaborator

I tend to agree with the change but the real change must be in the operator-manifests task to generate the files in the new destination folder.

Apart of that, I see also changes needed in the CI workflow to adapt to the new file structure.

@ChrisJBurns
Copy link
Collaborator

Thanks for this @lokeshrangineni, good spot! As @dmartinol mentioned, you'll need to update the relevant automated places where those are generated so that they're generated in the right place

…e crds directory rather than in templates directory to follow the helm standards.
@lokeshrangineni
Copy link
Contributor Author

I tend to agree with the change but the real change must be in the operator-manifests task to generate the files in the new destination folder.

Apart of that, I see also changes needed in the CI workflow to adapt to the new file structure.

@dmartinol Thank you for the feedback. I have incorporated the review comments also searched across the repo for operator-crds references. please let me know if i missed any other places.

cc: @ChrisJBurns

Copy link
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm!

ChrisJBurns
ChrisJBurns previously approved these changes Sep 17, 2025
@ChrisJBurns
Copy link
Collaborator

@lokeshrangineni I believe the Chart will need a bump

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2025

Coverage Status

coverage: 44.127% (+0.05%) from 44.079%
when pulling 495367c on lokeshrangineni:move-crds-to-crds-directory
into ac073e0 on stacklok:main.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.75%. Comparing base (ac073e0) to head (495367c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
+ Coverage   46.71%   46.75%   +0.03%     
==========================================
  Files         220      220              
  Lines       27378    27378              
==========================================
+ Hits        12791    12801      +10     
+ Misses      13615    13599      -16     
- Partials      972      978       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lokeshrangineni
Copy link
Contributor Author

@lokeshrangineni I believe the Chart will need a bump

I have bumped the chart release from 0.0.25 to 0.0.26. PTAL.

@ChrisJBurns ChrisJBurns merged commit a0caac5 into stacklok:main Sep 17, 2025
26 checks passed
@ChrisJBurns
Copy link
Collaborator

Thanks @lokeshrangineni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants