Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Sep 17, 2025

They need to be propagated as env vars, using the pod-patch, instead of being propagated as secrets, as they cause issue with the provider

In the future, we should actually modify that and use the withsecrets command, maybe adding some k8s secrets provider

Closes: #1873

@yrobla yrobla requested a review from ChrisJBurns September 17, 2025 13:00
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.79%. Comparing base (c4593a9) to head (1a66404).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...d/thv-operator/controllers/mcpserver_controller.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
- Coverage   46.93%   46.79%   -0.14%     
==========================================
  Files         220      220              
  Lines       27340    27378      +38     
==========================================
- Hits        12831    12812      -19     
- Misses      13533    13591      +58     
+ Partials      976      975       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2025

Coverage Status

coverage: 44.151% (-0.02%) from 44.166%
when pulling 1a66404 on issue-1873-v1
into 6084080 on main.

dmjb
dmjb previously approved these changes Sep 17, 2025
They need to be propagated as env vars, using the pod-patch, instead
of being propagated as secrets, as they cause issue with the provider

In the future, we should actually modify that and use the withsecrets
command, maybe adding some k8s secrets provider

Closes: #1873
@yrobla yrobla merged commit ac073e0 into main Sep 17, 2025
21 of 22 checks passed
@yrobla yrobla deleted the issue-1873-v1 branch September 17, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCPServers Using Secrets and RunConfig ConfigMap Fail Due to Secret Provider Setup Error

6 participants