- 
                Notifications
    
You must be signed in to change notification settings  - Fork 135
 
return the proxy mode in the server type for stdio #1975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the server type display logic to show the effective transport type (proxy mode) instead of the underlying transport type when listing MCP servers that use stdio with a proxy. This provides more accurate information to users about what they're actually connecting to.
- Adds logic to determine effective transport type based on proxy mode for stdio servers
 - Updates the display to show proxy mode (sse or streamable-http) instead of stdio when applicable
 - Adds comprehensive test coverage for the new transport type resolution logic
 
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description | 
|---|---|
| cmd/thv/app/list.go | Implements getEffectiveTransportType function and updates server listing to use effective transport type | 
| cmd/thv/app/list_test.go | Adds comprehensive unit tests for the new transport type resolution logic | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
+ Coverage   48.21%   48.27%   +0.05%     
==========================================
  Files         236      236              
  Lines       29654    29690      +36     
==========================================
+ Hits        14298    14333      +35     
- Misses      14277    14279       +2     
+ Partials     1079     1078       -1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should do this in the workload manager so that the behaviour is consistent across UI and API.
          
 ok fixed  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fb87216    to
    eaa8c83      
    Compare
  
    when we run a server via stdio, we wrap it into a proxy, exposing via sse or streamable-http. So show this as the server type, instead of the stdio type Closes: #1717
when we run a server via stdio, we wrap it into a proxy, exposing via sse or streamable-http. So show this as the server type, instead of the stdio type
Closes: #1717