Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Sep 19, 2025

when we run a server via stdio, we wrap it into a proxy, exposing via sse or streamable-http. So show this as the server type, instead of the stdio type

Closes: #1717

@yrobla yrobla requested a review from Copilot September 19, 2025 11:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the server type display logic to show the effective transport type (proxy mode) instead of the underlying transport type when listing MCP servers that use stdio with a proxy. This provides more accurate information to users about what they're actually connecting to.

  • Adds logic to determine effective transport type based on proxy mode for stdio servers
  • Updates the display to show proxy mode (sse or streamable-http) instead of stdio when applicable
  • Adds comprehensive test coverage for the new transport type resolution logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
cmd/thv/app/list.go Implements getEffectiveTransportType function and updates server listing to use effective transport type
cmd/thv/app/list_test.go Adds comprehensive unit tests for the new transport type resolution logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.27%. Comparing base (a0f517c) to head (e4d835e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/workloads/manager.go 0.00% 3 Missing ⚠️
pkg/workloads/types/types.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
+ Coverage   48.21%   48.27%   +0.05%     
==========================================
  Files         236      236              
  Lines       29654    29690      +36     
==========================================
+ Hits        14298    14333      +35     
- Misses      14277    14279       +2     
+ Partials     1079     1078       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JAORMX
JAORMX previously approved these changes Sep 19, 2025
dmjb
dmjb previously requested changes Sep 19, 2025
Copy link
Member

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should do this in the workload manager so that the behaviour is consistent across UI and API.

@yrobla
Copy link
Contributor Author

yrobla commented Sep 19, 2025

We probably should do this in the workload manager so that the behaviour is consistent across UI and API.

ok fixed

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yrobla yrobla force-pushed the issue-1717 branch 4 times, most recently from fb87216 to eaa8c83 Compare September 19, 2025 14:13
dmjb
dmjb previously approved these changes Oct 2, 2025
when we run a server via stdio, we wrap it into a proxy,
exposing via sse or streamable-http. So show this as the
server type, instead of the stdio type

Closes: #1717
@yrobla yrobla merged commit b58c533 into main Oct 2, 2025
43 of 44 checks passed
@yrobla yrobla deleted the issue-1717 branch October 2, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong transport when listing MCP servers with JSON/mcpservers format

5 participants