Skip to content

Conversation

@JAORMX
Copy link
Collaborator

@JAORMX JAORMX commented Sep 24, 2025

Problem

The CI was broken due to the security-scan.yml workflow missing the workflow_call trigger needed to make it reusable. This was causing the run-on-pr.yml workflow to fail when trying to call it at line 25.

Error message:

.github/workflows/run-on-pr.yml#L25
error parsing called workflow
".github/workflows/run-on-pr.yml"
-> "./.github/workflows/security-scan.yml"
: workflow is not reusable as it is missing a `on.workflow_call` trigger

Solution

Added the workflow_call: trigger to the security-scan.yml workflow while preserving all existing triggers:

  • workflow_dispatch
  • push (on main branch)
  • pull_request (on main branch)
  • schedule (daily at 2 AM UTC)

This follows the same pattern used by other reusable workflows in the repository like spellcheck.yml and lint.yml.

Testing

The fix can be verified by:

  1. The workflow syntax being valid
  2. The PR checks running successfully once this PR is created
  3. The security scan job completing as part of the overall CI pipeline

Changes

  • Added workflow_call: trigger to .github/workflows/security-scan.yml

The security-scan.yml workflow was missing the workflow_call trigger
needed to make it reusable. This was causing the run-on-pr.yml workflow
to fail when trying to call it.

Added workflow_call trigger while preserving existing triggers for
workflow_dispatch, push, pull_request, and scheduled runs.
@github-advanced-security
Copy link
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@JAORMX JAORMX merged commit 975da43 into main Sep 24, 2025
22 checks passed
@JAORMX JAORMX deleted the fix/ci-security-scan-workflow branch September 24, 2025 09:48
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.60%. Comparing base (5df8be5) to head (b7bf89c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
+ Coverage   47.58%   47.60%   +0.02%     
==========================================
  Files         232      232              
  Lines       28646    28646              
==========================================
+ Hits        13630    13636       +6     
+ Misses      13989    13985       -4     
+ Partials     1027     1025       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants