Skip to content

Add environment variable support for OIDC client secret #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

Add environment variable support for OIDC client secret #2325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/auth/token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"io"
"net/http"
"net/url"
"os"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -541,6 +542,14 @@ func NewTokenValidator(ctx context.Context, config TokenValidatorConfig) (*Token
registry.AddProvider(NewGoogleProvider(config.IntrospectionURL))
}

// Load client secret from environment variable if not provided in config
// This allows secrets to be injected via Kubernetes Secret references
if config.ClientSecret == "" {
if envSecret := os.Getenv("TOOLHIVE_OIDC_CLIENT_SECRET"); envSecret != "" {
config.ClientSecret = envSecret
}
}

// Add RFC7662 provider with auth if configured
if config.ClientID != "" || config.ClientSecret != "" {
rfc7662Provider, err := NewRFC7662ProviderWithAuth(
Expand Down
Loading