Skip to content

Conversation

@ChrisJBurns
Copy link
Collaborator

There is a lot of code that is inside the controllers package. This PR moves the GetToolConfigForMCPServer() function into a separate package for now (will probably get moved again in future when codebase architecture has become more stable) to keep things as small as possible and testable. This also removes the possible circular dependency loop that will happen in future refactoring changes relating to the RunConfig.

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.20%. Comparing base (2642816) to head (e1cfb71).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/thv-operator/controllers/mcpserver_controller.go 0.00% 1 Missing ⚠️
...md/thv-operator/controllers/mcpserver_runconfig.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   54.22%   54.20%   -0.02%     
==========================================
  Files         241      242       +1     
  Lines       23602    23602              
==========================================
- Hits        12798    12794       -4     
- Misses       9592     9595       +3     
- Partials     1212     1213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns enabled auto-merge (squash) October 27, 2025 22:49
@ChrisJBurns ChrisJBurns merged commit 1f3b689 into main Oct 27, 2025
44 of 45 checks passed
@ChrisJBurns ChrisJBurns deleted the moves-tool-config branch October 27, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants