Return tools_override in workload GET endpoint #2386
Merged
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GET endpoint for workloads was not returning the tools_override field even though it was being stored and applied correctly. This was because the runConfigToCreateRequest function was missing the logic to copy the ToolsOverride field from RunConfig to the API response. Added conversion logic to map runConfig.ToolsOverride to the API's toolsOverride format in the runConfigToCreateRequest function, along with a test case to ensure it works correctly. Fixes #2385 Co-authored-by: Chris Burns <ChrisJBurns@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
+ Coverage 54.29% 54.33% +0.03%
==========================================
Files 260 260
Lines 24925 24933 +8
==========================================
+ Hits 13534 13548 +14
+ Misses 10100 10089 -11
- Partials 1291 1296 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blkt
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GET endpoint for workloads was not returning the tools_override field even though it was being stored and applied correctly. This was because the runConfigToCreateRequest function was missing the logic to copy the ToolsOverride field from RunConfig to the API response.
Added conversion logic to map runConfig.ToolsOverride to the API's toolsOverride format in the runConfigToCreateRequest function, along with a test case to ensure it works correctly.
Fixes #2385