Add HTTP header validation to prevent injection #2411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ValidateHTTPHeaderName and ValidateHTTPHeaderValue functions to the validation package to prevent CRLF injection and other header-based attacks. These functions use golang.org/x/net/http/httpguts for RFC 7230 compliant validation, matching Go's own HTTP/2 implementation. The validation checks for: - CRLF injection attempts (\r\n) - Control characters (null bytes, etc.) - RFC 7230 token compliance for header names - Length limits (256 bytes for names, 8KB for values)
JAORMX
approved these changes
Oct 31, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
+ Coverage 54.54% 54.58% +0.03%
==========================================
Files 264 264
Lines 25351 25367 +16
==========================================
+ Hits 13828 13846 +18
+ Misses 10210 10208 -2
Partials 1313 1313 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ValidateHTTPHeaderName and ValidateHTTPHeaderValue functions to the validation package to prevent CRLF injection and other header-based attacks. These functions use golang.org/x/net/http/httpguts for RFC 7230 compliant validation, matching Go's own HTTP/2 implementation.
The validation checks for: