vMCP: Use proxy-mode instead of transport #2413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got hit by this again... We should be using proxy mode when determining the transport to use for an MCP, and not the MCPs underlying transport which is not useful for this scenario. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
amirejaz
approved these changes
Oct 31, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 54.43% 54.43% -0.01%
==========================================
Files 265 265
Lines 25590 25593 +3
==========================================
+ Hits 13931 13932 +1
- Misses 10338 10340 +2
Partials 1321 1321 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lujunsan
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got hit by this again... We should be using proxy mode when
determining the transport to use for an MCP, and not the MCPs underlying
transport which is not useful for this scenario.
Signed-off-by: Juan Antonio Osorio ozz@stacklok.com